From 2e42975a2095e89e6ed73c773816e96ab8819bb6 Mon Sep 17 00:00:00 2001 From: "Apoorv Verma [AP]" Date: Wed, 21 Aug 2019 21:52:30 -0700 Subject: [PATCH] [CentralDashboard v2] Added env_var for KFAM Server address (#298) * Added an environment variable to central dash to target the correct KFAM target * Addresed PR comments and updated tests --- common/centraldashboard/base/deployment.yaml | 2 ++ tests/centraldashboard-base_test.go | 2 ++ tests/centraldashboard-overlays-application_test.go | 2 ++ tests/centraldashboard-overlays-istio_test.go | 2 ++ 4 files changed, 8 insertions(+) diff --git a/common/centraldashboard/base/deployment.yaml b/common/centraldashboard/base/deployment.yaml index 84e67e84adc..2ed1e008e68 100644 --- a/common/centraldashboard/base/deployment.yaml +++ b/common/centraldashboard/base/deployment.yaml @@ -26,4 +26,6 @@ spec: value: $(userid-header) - name: USERID_PREFIX value: $(userid-prefix) + - name: PROFILES_KFAM_SERVICE_HOST + value: profiles-kfam.kubeflow serviceAccountName: centraldashboard diff --git a/tests/centraldashboard-base_test.go b/tests/centraldashboard-base_test.go index b414463d354..b6f046a3f02 100644 --- a/tests/centraldashboard-base_test.go +++ b/tests/centraldashboard-base_test.go @@ -76,6 +76,8 @@ spec: value: $(userid-header) - name: USERID_PREFIX value: $(userid-prefix) + - name: PROFILES_KFAM_SERVICE_HOST + value: profiles-kfam.kubeflow serviceAccountName: centraldashboard `) th.writeF("/manifests/common/centraldashboard/base/role-binding.yaml", ` diff --git a/tests/centraldashboard-overlays-application_test.go b/tests/centraldashboard-overlays-application_test.go index 66daa807624..c86d53b3899 100644 --- a/tests/centraldashboard-overlays-application_test.go +++ b/tests/centraldashboard-overlays-application_test.go @@ -145,6 +145,8 @@ spec: value: $(userid-header) - name: USERID_PREFIX value: $(userid-prefix) + - name: PROFILES_KFAM_SERVICE_HOST + value: profiles-kfam.kubeflow serviceAccountName: centraldashboard `) th.writeF("/manifests/common/centraldashboard/base/role-binding.yaml", ` diff --git a/tests/centraldashboard-overlays-istio_test.go b/tests/centraldashboard-overlays-istio_test.go index a84662020bb..d2fa3e318d2 100644 --- a/tests/centraldashboard-overlays-istio_test.go +++ b/tests/centraldashboard-overlays-istio_test.go @@ -114,6 +114,8 @@ spec: value: $(userid-header) - name: USERID_PREFIX value: $(userid-prefix) + - name: PROFILES_KFAM_SERVICE_HOST + value: profiles-kfam.kubeflow serviceAccountName: centraldashboard `) th.writeF("/manifests/common/centraldashboard/base/role-binding.yaml", `