Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Datadog metrics and tag filtering in Canary Analysis are in a misleading section #288

Open
goodspark opened this issue Oct 30, 2020 · 1 comment

Comments

@goodspark
Copy link

goodspark commented Oct 30, 2020

https://docs.armory.io/docs/spinnaker-user-guides/kayenta-canary-use/#metric-scopes

I was trying to setup canary analysis with Datadog and was trying to ensure that the metrics from my canary config group (eg. system.load.norm.1) was properly filtered.

I think the blurb about Datadog tags should either be moved up into the 'Configuring a Canary Analysis stage' section or further clarified that tag strings should go into the baseline/canary pair input fields, not the extended params.

Update

I think I see what went wrong.

The pictures in the current docs might be from an older version of the UI? Since the section called 'Metric Scopes' in Spinnaker 1.23.0 / Deck 3.4.0 seems to have moved and only encompasses the Extended Params, which aren't needed for Datadog.

From the docs:
https://docs.armory.io/images/Image-2018-04-18-at-1.48.11-PM.png

From Deck 3.4.0:
Screenshot from 2020-10-29 17-42-26

@aimeeu
Copy link
Contributor

aimeeu commented Oct 30, 2020

Thanks @goodspark for pointing this out! We've created an internal Jira item to track the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants