Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Set and Histogram #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Set and Histogram #98

wants to merge 1 commit into from

Conversation

beekus
Copy link
Member

@beekus beekus commented Jun 18, 2019

This PR adds the Set and Histogram metrics for the datadog sink.

Similar to Emit, I added these metrics to the MetricSink interface and made them noop for other sinks as per this slack thread.

@Eclion Eclion mentioned this pull request Aug 5, 2022
Open
@Eclion
Copy link

Eclion commented Aug 5, 2022

Hello!
Is there any update regarding this PR, aside from the need to rebase it?

@Eclion Eclion mentioned this pull request Aug 9, 2022
Open
@balena-zh
Copy link

This PR is useful, but the prometheus package is missing implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beekus @Eclion @balena-zh