why is Validate::No hardcoded in some impls?

[a-stevan]

hello there 👋

i was looking through the code of ark-serialize and found a few places where, even though a validate: Validate is passed as argument to a serialization function, it is hardcoded to Validate::No regardless of the value passed by the caller and passed down the line.

this looks like a bug to me, especially given the fact that compress: Compress is passed as-is to sub calls, but maybe there is a reason where the validation should be disabled in some places? 😮

hope this helps in some way 😇
cheers 😊

locations i found in the code

algebra/serialize/src/impls.rs

Line 462 in bb663bc

T::deserialize_with_mode(&mut reader, compress, Validate::No).unwrap()

algebra/serialize/src/impls.rs

Line 519 in bb663bc

Validate::No,

algebra/serialize/src/impls.rs

Line 616 in bb663bc

Validate::No,

algebra/serialize/src/impls.rs

Line 678 in bb663bc

Validate::No,

[a-stevan]

and if it's confirmed to be unintentional, i'd be happy to help you fix this issue in a PR 😉

[slumber]

Your links refer to implementations for collections, after deserializing without validation, impls do

if let Validate::Yes = validate {
    T::batch_check(values.iter())?
}

Which is correct.

[a-stevan]

ooooh, i see!

so each value is not validated individually, but if the user provides Validate::Yes, then all the values are validated at the end in a batch, is that correct?

thanks for the answer 🙏