Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate eslint v9 perf regression #1114

Closed
ssalbdivad opened this issue Aug 31, 2024 · 1 comment
Closed

Investigate eslint v9 perf regression #1114

ssalbdivad opened this issue Aug 31, 2024 · 1 comment

Comments

@ssalbdivad
Copy link
Member

I recently migrated the repo to v9. All the rules seem to work fine and be responsive in-editor, but the time to run pnpm eslint went from ~8 to ~25 seconds on my machine somehow.

Couldn't immediately figure out what was going on. Generally, linting is only run across the whole repo in CI, so I'm willing to keep up the updated config regardless with the hope there must be some misconfigured setting leading to this.

@ssalbdivad
Copy link
Member Author

Was able to resolve this by reverting from eslint-plugin-import-x to eslint-plugin-import with @eslint/compat.

It was due to un-ts/eslint-plugin-import-x#113

Thanks @JoshuaKGoldberg, @bradzacher for the help diagnosing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (merged or closed)
Development

No branches or pull requests

1 participant