Adding optimal ev (Train) feature, new app redesign, and Modal updates #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple tests for parts of the damage calculation engine. Tested weather and type effectiveness Tested neutral attack Seems all good so far!
Added class types because I learned the hard way that types are important! Added train_pokemon functionality, which allows for finding optimal evs I want to add features to allow for finding optimal evs for neutral and supereffective hits, as well as for multiple pokemon kos. It would be cool to also solve for 2hko, 3hko as well. :
- added some stuff to help do optimal ev calculation -wrote some tests to confirm this
- retrieves move data and writes it locally for calculation stuff! Eventually, I want to write this to a database as a sort of ETL pipeline probably, maybe with mage.ai.... that way the application doesn't have to be concerned with hosting the data it uses on deployment.
Also added ways to check if JSON is properly formatted. I need more tests to check for junk or broken JSON. Should be sufficient for demo for now, but will need to change soon
This commit adds the damage calculation LLM to modal and also allows for a bit of testing too!
Wrote a test for optimal ev calc stuff. Need way more tests. Will set aside time writing many for consistency.
This was
linked to
issues
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally adding another new feature which increases the usefulness of the app.
The Train feature allows for optimal EV calculation given a game state of information. This is a non-trivial task to do in pokemon damage calculator!
Had to write and refactor a whole mess of stuff, in addition to more tests. Still needs more work to be maximally useful (there is only a small pool of moves as of now, but I'll fix and update that soon!
-Arjun