Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either a bug or an error in documentation for encodePathSegments #102

Open
lagunoff opened this issue Jul 19, 2022 · 1 comment
Open

Either a bug or an error in documentation for encodePathSegments #102

lagunoff opened this issue Jul 19, 2022 · 1 comment

Comments

@lagunoff
Copy link

Here https://github.com/aristidb/http-types/blob/master/Network/HTTP/Types/URI.hs#L253 documentation states Performs percent encoding on all unreserved characters, as well as @\:\@\=\+\$@, while under the hood it calls urlEncodeBuilder False which does not escape characters :@&=+$,. Also in the docs the characters :@&=+$, called unreserved but they are actually reserved https://developers.google.com/maps/url-encoding. I also send related PR here fizruk/http-api-data#119

@Vlix
Copy link

Vlix commented Nov 30, 2023

Fixed in 0.12.4 [Vlix#1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants