From c2abc9921e526cd7cca491106e41969c079143c5 Mon Sep 17 00:00:00 2001 From: gmuloc Date: Mon, 22 Jul 2024 10:26:17 +0200 Subject: [PATCH 1/4] Doc(eos_designs): Remove lookup plugin reference for Zscaler IE --- .../arista/avd/roles/eos_designs/docs/how-to/wan.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md index 302c036f063..8de344d39c3 100644 --- a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md +++ b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md @@ -577,17 +577,10 @@ An internet-exit policy of type `zscaler` leverages the following AVD data model AVD supports up to three tunnels (primary, secondary, tertiary). -The target is for this data to be retrieved from Cloudvision through a lookup plugin for each device to determine what are the best tunnel(s) to use for a given location. - ```yaml -# Variables used by the lookup plugin to connect to Cloudvision cv_server: cv_token: - -# Lookup plugin usage -zscaler_endpoints: "{{ lookup('arista.avd.cv_zscaler_endpoints') }}" ``` - For each `zscaler` type Internet-policies, AVD uses the `cv_pathinfder_internet_exit_policies[name=].zscaler` dictionary and the `zscaler_endpoints` in combination with the `l3_interfaces.cv_pathfinder_internet_exit.policies[name=].tunnel_interface_numbers` to generate the internet-exit configuration. The `cv_pathinfder_internet_exit_policies[name=].zscaler` dictionary has additonnal options to configure the policy parameters shared with Zscaler through Cloudvision. From fd186c5805181e0da4961519cd2a126113c56bd0 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 22 Jul 2024 08:30:59 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- .../arista/avd/roles/eos_designs/docs/how-to/wan.md | 1 + 1 file changed, 1 insertion(+) diff --git a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md index 8de344d39c3..496db80fc16 100644 --- a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md +++ b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md @@ -581,6 +581,7 @@ AVD supports up to three tunnels (primary, secondary, tertiary). cv_server: cv_token: ``` + For each `zscaler` type Internet-policies, AVD uses the `cv_pathinfder_internet_exit_policies[name=].zscaler` dictionary and the `zscaler_endpoints` in combination with the `l3_interfaces.cv_pathfinder_internet_exit.policies[name=].tunnel_interface_numbers` to generate the internet-exit configuration. The `cv_pathinfder_internet_exit_policies[name=].zscaler` dictionary has additonnal options to configure the policy parameters shared with Zscaler through Cloudvision. From b41e4aa269e843a3f8706ea9b9ff4e1e22fb7e14 Mon Sep 17 00:00:00 2001 From: Guillaume Mulocher Date: Mon, 22 Jul 2024 14:39:40 +0200 Subject: [PATCH 3/4] Apply suggestions from code review Co-authored-by: Claus Holbech --- .../arista/avd/roles/eos_designs/docs/how-to/wan.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md index 496db80fc16..dab40eb6b1e 100644 --- a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md +++ b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md @@ -576,10 +576,12 @@ interface Ethernet3 An internet-exit policy of type `zscaler` leverages the following AVD data model to generate the target configuration. AVD supports up to three tunnels (primary, secondary, tertiary). +AVD `eos_designs` will fetch Zscaler integration information from Cloudvision. ```yaml +# Variables used by eos_designs to connect to Cloudvision cv_server: -cv_token: +cv_token: ``` For each `zscaler` type Internet-policies, AVD uses the `cv_pathinfder_internet_exit_policies[name=].zscaler` dictionary and the `zscaler_endpoints` in combination with the `l3_interfaces.cv_pathfinder_internet_exit.policies[name=].tunnel_interface_numbers` to generate the internet-exit configuration. From c81e5ab0f11a66e770c66be2b3b7e764cb541141 Mon Sep 17 00:00:00 2001 From: Guillaume Mulocher Date: Mon, 22 Jul 2024 14:39:50 +0200 Subject: [PATCH 4/4] Apply suggestions from code review --- .../arista/avd/roles/eos_designs/docs/how-to/wan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md index dab40eb6b1e..2cafff1fe47 100644 --- a/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md +++ b/ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md @@ -580,7 +580,7 @@ AVD `eos_designs` will fetch Zscaler integration information from Cloudvision. ```yaml # Variables used by eos_designs to connect to Cloudvision -cv_server: +cv_server: cv_token: ```