-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Added rack, pod, dc, fabric information in the structured_config metadata #4827
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4827
# Activate the virtual environment
source test-avd-pr-4827/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4805#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4805 --force
# Optional: Install AVD examples
cd test-avd-pr-4827
ansible-playbook arista.avd.install_examples |
edb9339
to
3e5fbfd
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Mahesh
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/metadata.schema.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI passes
Change Summary
Added rack, pod, dc, fabric information in the structured_config metadata.
Related Issue(s)
Fixes #4805
Component(s) name
arista.avd.eos_designs
Proposed changes
Added rack, pod, dc, fabric information in the structured_config metadata.
How to test
Run molecule
Checklist
User Checklist
Repository Checklist