Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: verify-requirement does not handle requirements with comments afterwards #3122

Closed
gmuloc opened this issue Sep 6, 2023 · 0 comments · Fixed by #3125
Closed

Feat: verify-requirement does not handle requirements with comments afterwards #3122

gmuloc opened this issue Sep 6, 2023 · 0 comments · Fixed by #3125

Comments

@gmuloc
Copy link
Contributor

gmuloc commented Sep 6, 2023 

          addressed in https://github.com/aristanetworks/ansible-avd/commit/de04df313f6991308683742ffa0528b81d5d8ec9

our verify-requirement does not understand comments after the line so I put it above. will need to log an issue for this probably

Originally posted by @gmuloc in https://github.com/aristanetworks/ansible-avd/pull/2907#discussion_r1317054398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Support inline comments in requirements.txt gmuloc/avd
1 participant
@gmuloc