Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output for coverage.json and License #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

binchensjtu
Copy link

Hello arikon, I would also like to generate coverage.json .
So I add some code for you.
Aslo. I add a MIT license which is missing but it is declared in https://npmjs.org/package/mocha-istanbul

@arikon
Copy link
Owner

arikon commented Jun 12, 2015

If it is still relevant, could you rebase?

@@ -16,21 +16,30 @@ exports = module.exports = Istanbul;
*/
function Istanbul(runner) {

runner.on('end', function(){
runner.on('end', function () {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change code style, please

@binchensjtu
Copy link
Author

Wow... such a long time... I am almost forget this. I am not working on that any more. You can close it. Thanks all the same.

@arikon
Copy link
Owner

arikon commented Jun 15, 2015

@binchensjtu I missed notification from github in a bunch of others =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants