Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example not working in Safari #65

Closed
rothsandro opened this issue Apr 5, 2018 · 7 comments
Closed

Example not working in Safari #65

rothsandro opened this issue Apr 5, 2018 · 7 comments

Comments

@rothsandro
Copy link

The example is not working in Safari 10.0.3 on OS X 10.11.6:

SyntaxError: Cannot declare a let variable twice: 'e'.
@arielsalminen
Copy link
Owner

arielsalminen commented Apr 6, 2018

@rothsandro Thanks for reporting this! The living docs only supports the few latest versions of Safari (see https://github.com/viljamis/vue-design-system/wiki/frequently-asked-questions-(FAQ)#what-browsers-are-supported for browser support), and I’m guessing that is related to Safari 10’s bug with let variables: https://caniuse.com/#feat=let

I will see if there’s an easy way to fix this though as 10 isn’t that old.

@arielsalminen
Copy link
Owner

@rothsandro I think this is related to: vue-styleguidist/vue-styleguidist#83

@rothsandro
Copy link
Author

Yes, seems to be related. The last time I used Vue Styleguidist, the production build was not working in Safari.

@arielsalminen
Copy link
Owner

Looking into this now and hoping it will get fixed in #82

@arielsalminen
Copy link
Owner

@rothsandro looks like it’s working now. I do get a warning in console which is caused by something in Styleguidist, but at least everything’s working and it’s completely usable.

@arielsalminen
Copy link
Owner

(I haven’t published this fix yet though)

@arielsalminen
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants