-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitle navigation for autogenerated subs broken #4
Comments
Hi, thanks for reaching out sp3ctum. This is an issue related to the I've found that by sticking to Before I ported the app to use VLC, you could actually use the player in portrait mode and you wouldn't be restricted in landscape mode. So it's less buggy, I restrict the player in landscape. In this case, I believe only the This results in some unspecified behavior towards the end of a video and really weird seeking. It's a tradeoff I must deal with for the moment, and I've decided it's something most users can live with rather than being restricted to a poor quality YouTube video only in 360p or so. For now, I advise users not to trust seeks too much when streaming video. Thanks again for the bug report, I really appreciate it. I will continue to investigate what I can do about this. I will leave this issue open as it is a legitimate concern. |
I have recently released 0.12.4 as a quick mitigation for this issue. I now mix muxed and demuxed YouTube streams. You may find muxed YouTube streams marked as I've found great success using these on more than an hour long videos (which I've found are typically problematic) where attempting to seek will return you to the beginning of the video. Muxed streams are very compatible with the player but are limited to 720p at the maximum quality however, so please be advised. I think this is a pretty solid temporary solution while I get to the heart of the matter. |
Tested that release today with a couple of videos, seems to work nicely. It's a huge improvement, thank you 👍 |
After letting this issue stay open for months, I believe this is a deeply rooted VLC issue with the I will keep the seek friendly tags for now and will consider a next point of action after seeing how compatibility goes after this change which I implemented in the 0.25.1 hotfix and may drop them at a later version. For compatibility purposes, I'll keep the seek friendly tags as the muxed streams are basically guaranteed to work very well. And maybe, at a later date if everything is basically working great, I will drop those tags. As this is not really an issue with the app and this version of VLC that comes bundled with the video player package I use is all I can work with, making sure that it's as compatible as it can be with the codecs I feed into it is the best I can do. And from what I've tested with, there is a very significant improvement to seekability in highest resolution streams, so I am finally closing this issue. Sorry for the long wait. |
Hi, just found out that if I enable autogenerated subs and navigate to one of the last subtitle lines, the video seems to start over in a weird manner instead of going to the end.
Tried it with this video on 0.12.1 beta
https://youtu.be/-i8Nl4zPq20
The text was updated successfully, but these errors were encountered: