Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moldovan format is incorrect #23

Closed
LaurentVB opened this issue Nov 11, 2015 · 4 comments
Closed

Moldovan format is incorrect #23

LaurentVB opened this issue Nov 11, 2015 · 4 comments

Comments

@LaurentVB
Copy link
Collaborator

According to SWIFT's IBAN registry (https://www.swift.com/dsp/resources/documents/IBAN_Registry.pdf), the format for moldovan IBAN is MD2!n20!c but in the lib, we validate on MD2!n18!c.

@itoche
Copy link
Contributor

itoche commented Nov 12, 2015

Hi Laurent,
Are you sure?
Digging into your code, I see that the BBAN is 2 chars for the bank than 18 digits (U02F18). That makes the 20 chars following the country code (2 char) and 2 digits.
I make a test with the IBAN provided as example in the specs and it is fine.

Which issue did you experience? Any example?

Thx

@LaurentVB
Copy link
Collaborator Author

@itoche
Copy link
Contributor

itoche commented Nov 12, 2015

O, I get it.
Specs mentions that the BBAN is 2 chars then 18 chars. But we check 18 digits. The stackoverflow example is MD75EX0900002374642125EU, containing two last chars.
I'll push the fix.

@itoche itoche closed this as completed in b7822a5 Nov 12, 2015
@ilyass-ejjaouchi
Copy link

try to fix the library, it dosent support those IBAN numbers:
BE01234567896789
ES4701234567890123456789
IT5601234567890123456789123
GB69012345678923456789
DE58012345678923456789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants