Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Dark mode as opt-in #495

Open
gregorypratt opened this issue Apr 15, 2024 · 2 comments
Open

Request: Dark mode as opt-in #495

gregorypratt opened this issue Apr 15, 2024 · 2 comments

Comments

@gregorypratt
Copy link

We don't have an requirements to create a "Dark mode" variant of our website. However when dark mode is preferred certain aspects of the base styles do update due to @media (--OSdark) {.

The prop is fine but could the rules be refactored into an optional "extra" that gives us an opt-in approach, similar to normalise and buttons etc.? Thank you.

@argyleink
Copy link
Owner

are you looking for a light theme only version of normalize? here's a good example on how you can do that, there is a light theme only version you can import instead of the auto-adapting one.

that solve the issue for you? or did i misunderstand something? 🤓

@gregorypratt
Copy link
Author

Almost 😄 basically I think it would be nice if it were the other way around, no dark mode within open-props at all as the default, and add a dark mode support as an "extra".

Basically these rules should be part of a new src/extra/dark-mode.css for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants