fix: Correctly order emissary combined output. Fixes #8159 #8175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
alexec
changed the title
Signed-off-by: Alex Collins <[email protected]>
terrytangyuan
approved these changes
Mar 17, 2022
| err := run(x, []string{"echo", "hello", "/dev/stderr"}) | ||
| assert.NoError(t, err) | ||
| data, err := ioutil.ReadFile(varRunArgo + "/ctr/main/stderr") | ||
| data, err := ioutil.ReadFile(varRunArgo + "/ctr/main/combined") |
There was a problem hiding this comment.
Perhaps testing more complex output here and make sure the order is correct
sarabala1979
pushed a commit
that referenced
this pull request
Mar 18, 2022
* fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
Mar 23, 2022
…rgoproj#8175) * fix: Correctly order emissary combined output. Fixes argoproj#8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes argoproj#8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes argoproj#8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes argoproj#8168 Signed-off-by: Alex Collins <[email protected]>
sarabala1979
pushed a commit
that referenced
this pull request
Apr 18, 2022
* fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> Signed-off-by: Saravanan Balasubramanian <[email protected]>
sarabala1979
pushed a commit
that referenced
this pull request
Apr 18, 2022
* fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> * fix: Correctly order emissary combined output. Fixes #8168 Signed-off-by: Alex Collins <[email protected]> Signed-off-by: Saravanan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
Fixes #8159