Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to override default resources.limits with none #13697

Open
tooptoop4 opened this issue Oct 3, 2024 · 3 comments
Open

option to override default resources.limits with none #13697

tooptoop4 opened this issue Oct 3, 2024 · 3 comments
Labels
solution/workaround There's a workaround, might not be great, but exists type/feature Feature request

Comments

@tooptoop4
Copy link
Contributor

tooptoop4 commented Oct 3, 2024

https://argo-workflows.readthedocs.io/en/release-3.5/cost-optimisation/#configure-executor-resource-requests shows how to set default limits (ie cpu/memory) for all workflows

would like ability for one workflow to do an override of setting no limits
i tried cpu: null but it did not work

@tooptoop4 tooptoop4 added the type/feature Feature request label Oct 3, 2024
@jswxstw
Copy link
Member

jswxstw commented Oct 17, 2024

Have you tried PodSpecPatch?

@tooptoop4
Copy link
Contributor Author

PodSpecPatch adds unnecessary latency

@jswxstw
Copy link
Member

jswxstw commented Oct 18, 2024

Argo is not inherently a low-latency task scheduling system, so the latency is almost negligible compared to the scheduling time.
Moreover, to implement this feature, the method is almost identical to PodSpecPatch.

@jswxstw jswxstw added the solution/workaround There's a workaround, might not be great, but exists label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/workaround There's a workaround, might not be great, but exists type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants