Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set StableRS hash to current if replicaset does not actually exist #320

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

dthomson25
Copy link
Member

@dthomson25 dthomson25 commented Dec 3, 2019

Resolves #305

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #320 into master will increase coverage by 0.24%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   83.89%   84.13%   +0.24%     
==========================================
  Files          66       66              
  Lines        6028     6027       -1     
==========================================
+ Hits         5057     5071      +14     
+ Misses        698      683      -15     
  Partials      273      273
Impacted Files Coverage Δ
rollout/sync.go 76.04% <100%> (-0.07%) ⬇️
rollout/context.go 96.07% <100%> (-0.04%) ⬇️
utils/replicaset/canary.go 79.71% <100%> (+11.32%) ⬆️
rollout/canary.go 86.23% <83.33%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3260e...c413dc3. Read the comment docs.

@dthomson25 dthomson25 merged commit 99acc79 into master Dec 5, 2019
@dthomson25 dthomson25 deleted the stable-rs-gone branch December 5, 2019 21:22
tomsanbear pushed a commit to tomsanbear/argo-rollouts that referenced this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollout does not progress current stepIndex when "stable" RS is gone
2 participants