From 511158286462192a2c55d1a4ef36aae7d4e42dac Mon Sep 17 00:00:00 2001 From: Justin Marquis <34fathombelow@protonmail.com> Date: Wed, 14 Dec 2022 17:55:40 -0800 Subject: [PATCH 1/2] chore: update stable tag conditionally Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> --- .github/workflows/release.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index be2b5465c0..a71aa12c96 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -6,6 +6,11 @@ on: tag: description: Git tag to build release from required: true + update_stable_tag: + description: 'Update stable tag for docs' + required: true + type: boolean + default: 'false' permissions: contents: read @@ -186,7 +191,8 @@ jobs: - name: update stable tag for docs run: | git tag -f stable ${{ github.event.inputs.tag }} - git push -f origin stable + git push -f origin stable + if: ${{ inputs.update_stable_tag }} - name: Draft release uses: softprops/action-gh-release@v1 From 5769875f2713428523927c3bf226685d388b6057 Mon Sep 17 00:00:00 2001 From: Justin Marquis <34fathombelow@protonmail.com> Date: Wed, 14 Dec 2022 21:14:14 -0800 Subject: [PATCH 2/2] updated requested changes Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> --- .github/workflows/release.yaml | 2 +- docs/releasing.md | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index a71aa12c96..9401f83af8 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -7,7 +7,7 @@ on: description: Git tag to build release from required: true update_stable_tag: - description: 'Update stable tag for docs' + description: 'Update stable tag' required: true type: boolean default: 'false' diff --git a/docs/releasing.md b/docs/releasing.md index 8ac0a4d450..d4571c076c 100644 --- a/docs/releasing.md +++ b/docs/releasing.md @@ -5,18 +5,14 @@ 1. Visit the [Release GitHub Action](https://github.com/argoproj/argo-rollouts/actions/workflows/release.yaml) and enter the tag. +1. To automatically update the stable tag, select `Update stable tag`. (false by default) + [![GitHub Release Action](release-action.png)](release-action.png) 1. When the action completes, visit the generated draft [Github releases](https://github.com/argoproj/argo-rollouts/releases) and enter the details about the release: * Getting started (copy from previous release and new version) * Changelog -1. Update `stable` tag: - - ```bash - git tag stable --force && git push $REPO stable --force - ``` - 1. Update Brew formula: * Fork the repo https://github.com/argoproj/homebrew-tap