Contour support

[victornoel]

It would be great to have contour support for traffic management.

[ghostsquad]

Can you describe more specifically what this is asking for?

[victornoel]

@ghostsquad yes sorry.

So Contour is an ingress controller, like nginx-ingress. I saw in the doc that the latter was supported for traffic management, so I thought naively that contour was not.

I have no idea what must be done to support contour, maybe it's already working because argo-rollouts is only using ingresses?

[ghostsquad]

@victornoel based on the docs (https://argoproj.github.io/argo-rollouts/features/traffic-management/#how-does-argo-rollouts-enable-traffic-management) this is the right place for the request. I just know from experience that very sparse issues won't get as much attention as tickets like #516 which asks for Traefik Traffic Management, that go into a little bit more depth about the specific integration problem, including links back to Traefik docs. (Also I'm not a maintainer of this repo, just browsing)

[lienerieksta]

At the moment argo-rollouts would not work with contour because it manipulates specific CRD's or ingress annotations that are used by certain tools.

Contour supports more advanced traffic routing with HttpProxy: https://projectcontour.io/docs/v1.13.1/config/request-routing/#upstream-weighting

So argo-rollouts should gain the ability to manipulate the route weights of the HttpProxy object to be able to work with Contour. It already does something very similar with Istio VirtualService, so I don't think this is a complicated request.

[kostis-codefresh]

It seems that contour will have an implementation for the Kubernetes Gateway API https://gateway-api.sigs.k8s.io/implementations/#contour

So Contour support might be available after implementing #1438

[github-actions]

This issue is stale because it has been open 60 days with no activity.

[ghostsquad]

not stale

[wilsonwu]

@jessesuen Hi Jesse, do you think support contour by plugin way is acceptable? We'd like to contribute.
For example like: https://github.com/argoproj-labs/rollouts-gatewayapi-trafficrouter-plugin

[wilsonwu]

@jessesuen Hi Jesse, do you think support contour by plugin way is acceptable? We'd like to contribute. For example like: https://github.com/argoproj-labs/rollouts-gatewayapi-trafficrouter-plugin

@zachaller Zach, do you have any opinion for this?

[zachaller]

@wilsonwu Yes, this is exactly what plugins where created for and they will go out in 1.5 there is not a lot of docs yet but there is this https://argo-rollouts.readthedocs.io/en/latest/plugins/ and some light weight example ones in the argo rollouts repo here I am also planing on doing a blog series on creating plugins as well.

[wilsonwu]

@zachaller Thanks for your reply, so could you please help to create a repo: rollouts-contour-httpproxy-plugin

[zachaller]

@wilsonwu https://github.com/argoproj-labs/rollouts-contour-trafficrouter-plugin

[wilsonwu]

Got it, we will start to contribute, and any update will be synced here.

[izturn]

hey, @zachaller is there a workable image that contains #2573? i need it to test the plugin for contour

[zachaller]

@izturn 1.5.0-rc1 was released just now https://github.com/argoproj/argo-rollouts/releases/tag/v1.5.0-rc1

[izturn]

nice

[wilsonwu]

@zachaller, the contour trafficerouter plugin v0.1.0 released: https://github.com/argoproj-labs/rollouts-contour-trafficrouter-plugin/releases/tag/v0.1.0

[zachaller]

@wilsonwu awesome, whenever you think you are ready feel free to open a PR agains the docs here https://argo-rollouts.readthedocs.io/en/latest/features/traffic-management/plugins/#add-your-plugin-here

[wilsonwu]

@wilsonwu awesome, whenever you think you are ready feel free to open a PR agains the docs here https://argo-rollouts.readthedocs.io/en/latest/features/traffic-management/plugins/#add-your-plugin-here

Sure, I will update it ASAP.

[zachaller]

Closing due to it being implemented in both gateway api and as it's own plugin