Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the link of DCO in PR template #3944

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

chansuke
Copy link
Contributor

Update the link in PR template to the CONTRIBUTING.md which has a description of DCO.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

sonarcloud bot commented Nov 14, 2024

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (53c4f12) to head (0a210f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3944      +/-   ##
==========================================
+ Coverage   82.66%   82.76%   +0.09%     
==========================================
  Files         163      163              
  Lines       22895    22895              
==========================================
+ Hits        18927    18948      +21     
+ Misses       3092     3078      -14     
+ Partials      876      869       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 18m 35s ⏱️
113 tests 101 ✅  7 💤 5 ❌
460 runs  425 ✅ 28 💤 7 ❌

For more details on these failures, see this check.

Results for commit 0a210f0.

Copy link
Contributor

Published Unit Test Results

2 280 tests   2 280 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 0a210f0.

@zachaller zachaller merged commit e0968a9 into argoproj:master Nov 14, 2024
23 checks passed
Rizwana777 pushed a commit to Rizwana777/argo-rollouts that referenced this pull request Dec 12, 2024
chore: update the link of DCO

Signed-off-by: chansuke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants