Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference multiple analysis templates in a rollout's analysis #384

Closed
dthomson25 opened this issue Jan 26, 2020 · 2 comments · Fixed by #409
Closed

Reference multiple analysis templates in a rollout's analysis #384

dthomson25 opened this issue Jan 26, 2020 · 2 comments · Fixed by #409

Comments

@dthomson25
Copy link
Member

Currently, Rollouts can only reference one analysis template for an analysis step or a background analysis. Instead, the rollout should be able to specify multiple analysis templates and then create analysis runs from these templates. This makes it easier to have separate modular analysis runs instead of users creating a single analysis template.

Questions for the implementations:

  1. Should the controller combine all the analysis templates into one analysis run or create multiple analysis templates?
@jessesuen
Copy link
Member

Should the controller combine all the analysis templates into one analysis run or create multiple analysis templates?

When multiple AnalysisTemplates are referenced, we should compose them into a single AnalysisRun for simplicity.

@dthomson25
Copy link
Member Author

Note: #348 is dependent on this ticket since it will introduce Analysis to BG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants