Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Trustly to USERS.md #3837

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

bishalthapa-t
Copy link
Contributor

@bishalthapa-t bishalthapa-t commented Sep 17, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Bishal Thapa <[email protected]>
@bishalthapa-t bishalthapa-t changed the title chore: Add Trustly to users chore: Add Trustly to USERS.md Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Published E2E Test Results

  4 files    4 suites   3h 15m 37s ⏱️
113 tests 103 ✅  7 💤 3 ❌
456 runs  424 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit f798633.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Published Unit Test Results

2 275 tests   2 275 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit f798633.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (b8a9bf5) to head (f798633).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3837      +/-   ##
==========================================
+ Coverage   83.88%   83.92%   +0.04%     
==========================================
  Files         163      163              
  Lines       18560    18560              
==========================================
+ Hits        15569    15577       +8     
+ Misses       2119     2115       -4     
+ Partials      872      868       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Zach Aller <[email protected]>
@zachaller zachaller enabled auto-merge (squash) September 18, 2024 00:58
Copy link

sonarcloud bot commented Sep 18, 2024

@bishalthapa-t
Copy link
Contributor Author

@zachaller Looks like DCO is failing as it's missing Signed-off-by: due to this commit
f798633
or is it something else ?

@zachaller zachaller merged commit e51e924 into argoproj:master Sep 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants