Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replicaSet not scaled down due to incorrect annotations (#3762) #3784

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Aug 12, 2024

Closes #3762

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Published E2E Test Results

  4 files    4 suites   3h 25m 14s ⏱️
112 tests 102 ✅  7 💤 3 ❌
454 runs  420 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit 12193b5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Published Unit Test Results

2 257 tests   2 257 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 12193b5.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (f6ce5ce) to head (12193b5).
Report is 61 commits behind head on master.

Files with missing lines Patch % Lines
rollout/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3784   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         161      161           
  Lines       18495    18495           
=======================================
  Hits        15536    15536           
  Misses       2097     2097           
  Partials      862      862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <[email protected]>
Copy link

sonarcloud bot commented Aug 12, 2024

@zachaller zachaller marked this pull request as ready for review August 12, 2024 17:01
@zachaller zachaller merged commit 3c15eb1 into argoproj:master Aug 12, 2024
24 of 25 checks passed
zachaller pushed a commit that referenced this pull request Aug 13, 2024
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.7 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old replica sets not always scaling down after update from 1.6.6 to 1.7.1
2 participants