Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Get the right resourceName for traefik.io.Fixes #3615 #3759

Merged

Conversation

BrunoTarijon
Copy link
Contributor

@BrunoTarijon BrunoTarijon commented Jul 31, 2024

When the var(apiGroupToResource) is executed and we set the traefik api to traefik.io, using the cli flag, the value is not yet setted with SetTraefikAPIGroup(). So the value for traefik.io is not in the map. I changed to a function that is only executed when it is called.

This try to fix the #3615 issue.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@BrunoTarijon BrunoTarijon force-pushed the fix_traefik_io_resource_name branch from d7b70f6 to a253778 Compare July 31, 2024 17:59
Copy link

sonarcloud bot commented Jul 31, 2024

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 24m 23s ⏱️
111 tests 103 ✅  6 💤 2 ❌
446 runs  420 ✅ 24 💤 2 ❌

For more details on these failures, see this check.

Results for commit dd369bc.

Copy link
Contributor

Published Unit Test Results

2 174 tests   2 174 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit dd369bc.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (6c873a9) to head (dd369bc).
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
+ Coverage   84.23%   84.31%   +0.08%     
==========================================
  Files         154      154              
  Lines       18021    18025       +4     
==========================================
+ Hits        15180    15198      +18     
+ Misses       1998     1991       -7     
+ Partials      843      836       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit 708db68 into argoproj:master Aug 1, 2024
27 checks passed
zachaller pushed a commit that referenced this pull request Aug 13, 2024
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.7 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants