-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add update verb to ClusterRole permissions for scaleDown feature. Fixes #3672 #3675
fix: add update verb to ClusterRole permissions for scaleDown feature. Fixes #3672 #3675
Conversation
Go Published Test Results2 163 tests 2 163 ✅ 2m 54s ⏱️ Results for commit d89081b. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3675 +/- ##
=======================================
Coverage 80.27% 80.27%
=======================================
Files 156 156
Lines 17964 17964
=======================================
Hits 14420 14420
Misses 2631 2631
Partials 913 913 ☔ View full report in Codecov by Sentry. |
Signed-off-by: EnriqueTejeda <[email protected]>
3ad2b1a
to
d89081b
Compare
E2E Tests Published Test Results 4 files 4 suites 3h 24m 3s ⏱️ For more details on these failures, see this check. Results for commit d89081b. |
would it be possible to release 1.7.2 with this commit? its blocking usage of a feature released in 1.7.0 that didnt have relevant permissions for ref: argoproj/argo-helm#2795 |
…Fixes #3672 (#3675) fix: add update verb to ClusterRole permissions for scaleDown Signed-off-by: EnriqueTejeda <[email protected]>
Fixes: #3672
Add the
update
verb in the ClusterRole permissions to allow argo-rollouts to update deployments. This fixes the issue with the scaleDown feature not working due to missing permissions. (#3672)Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.