Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add update verb to ClusterRole permissions for scaleDown feature. Fixes #3672 #3675

Merged

Conversation

EnriqueTejeda
Copy link
Contributor

@EnriqueTejeda EnriqueTejeda commented Jun 26, 2024

Fixes: #3672

Add the update verb in the ClusterRole permissions to allow argo-rollouts to update deployments. This fixes the issue with the scaleDown feature not working due to missing permissions. (#3672)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Go Published Test Results

2 163 tests   2 163 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit d89081b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (4f1edbe) to head (d89081b).
Report is 81 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3675   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files         156      156           
  Lines       17964    17964           
=======================================
  Hits        14420    14420           
  Misses       2631     2631           
  Partials      913      913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EnriqueTejeda EnriqueTejeda force-pushed the fix-missing-permission-scaledown branch from 3ad2b1a to d89081b Compare June 26, 2024 22:28
@EnriqueTejeda EnriqueTejeda changed the title fix: update ClusterRole permissions for scaleDown fix: add update verb to ClusterRole permissions for scaleDown Jun 26, 2024
@EnriqueTejeda EnriqueTejeda changed the title fix: add update verb to ClusterRole permissions for scaleDown fix: add update verb to ClusterRole permissions for scaleDown feature Jun 26, 2024
@EnriqueTejeda EnriqueTejeda changed the title fix: add update verb to ClusterRole permissions for scaleDown feature fix: add update verb to ClusterRole permissions for scaleDown feature. Fixes #3672 Jun 26, 2024
Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 24m 3s ⏱️
111 tests 103 ✅  6 💤 2 ❌
446 runs  420 ✅ 24 💤 2 ❌

For more details on these failures, see this check.

Results for commit d89081b.

@zachaller zachaller merged commit f21956c into argoproj:master Jun 27, 2024
27 checks passed
@DrFaust92
Copy link
Contributor

would it be possible to release 1.7.2 with this commit? its blocking usage of a feature released in 1.7.0 that didnt have relevant permissions

for ref: argoproj/argo-helm#2795

zachaller pushed a commit that referenced this pull request Aug 13, 2024
…Fixes #3672 (#3675)

fix: add update verb to ClusterRole permissions for scaleDown

Signed-off-by: EnriqueTejeda <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.7 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing permission in ArgoRollout cluster role
3 participants