Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't fail code-cov on failure #3661

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jun 21, 2024

Codecov is going through a change requiring tokens, they are suppose to auto figure out if it's a PR and do a tokenless but they are having issue making it flaking this has been going on for a while now. Let's not fail pipeline on failures for the time being.

DSpace/DSpace#9630

codecov/engineering-team#1574 (comment)

Signed-off-by: Zach Aller <[email protected]>
@zachaller zachaller changed the title fix: don't fail code-cov on failure chore: don't fail code-cov on failure Jun 21, 2024
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller enabled auto-merge (squash) June 21, 2024 15:23
Copy link
Contributor

Go Published Test Results

2 163 tests   2 163 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit effc47c.

@zachaller zachaller merged commit f2b155d into argoproj:master Jun 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants