Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix and add more cli usage case #3592

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented May 23, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (f656735) to head (15d335b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3592      +/-   ##
==========================================
- Coverage   80.27%   80.27%   -0.01%     
==========================================
  Files         156      156              
  Lines       17966    17964       -2     
==========================================
- Hits        14422    14420       -2     
  Misses       2631     2631              
  Partials      913      913              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 23, 2024

Go Published Test Results

2 164 tests   2 164 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 15d335b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 23, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 28m 52s ⏱️
111 tests 100 ✅  6 💤 5 ❌
454 runs  421 ✅ 24 💤 9 ❌

For more details on these failures, see this check.

Results for commit 15d335b.

♻️ This comment has been updated with latest results.

@zachaller zachaller force-pushed the fix/status-cli-usage-err branch from 3be8620 to 15d335b Compare June 13, 2024 18:55
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.2% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit b83ef70 into argoproj:master Jun 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants