Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to unpause rollout in the getting started example #312

Closed
mathetake opened this issue Nov 29, 2019 · 0 comments · Fixed by #315
Closed

failed to unpause rollout in the getting started example #312

mathetake opened this issue Nov 29, 2019 · 0 comments · Fixed by #315
Assignees
Labels
docs Needs documentation/release notes

Comments

@mathetake
Copy link
Contributor

mathetake commented Nov 29, 2019

The way to resume rollouts described here seems not to work.

looks like

if len(rollout.Status.PauseConditions) > 0 || r.Spec.Paused || isScalingEvent {

this condition prevents unpauses even if we set spec.paused: false since we always have len(rollout.Status.PauseConditions) > 0

The alternative solution i found is

kubectl patch rollouts.argoproj.io example-rollout --type merge -p '{"status": {"pauseConditions": []}}'

or install the kubectl plugin and execute

kubectl argo rollouts promote example-rollout

By looking into the implementation of promote command, they are internally different.

Which one should I use?
According to the answer here, the getteing started documentation should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Needs documentation/release notes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants