Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify external clusters #3058

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

kostis-codefresh
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Kostis (Codefresh) <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Go Published Test Results

2 045 tests   2 044 ✔️  2m 41s ⏱️
   118 suites         0 💤
       1 files           1

For more details on these failures, see this check.

Results for commit 5d4ddf5.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 41m 28s ⏱️
102 tests   88 ✔️   6 💤   8
422 runs  385 ✔️ 24 💤 13

For more details on these failures, see this check.

Results for commit 5d4ddf5.

@zachaller zachaller enabled auto-merge (squash) September 25, 2023 12:35
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2aeabf4) 81.75% compared to head (5d4ddf5) 81.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3058   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         134      134           
  Lines       20395    20395           
=======================================
  Hits        16674    16674           
  Misses       2865     2865           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit 6a231bf into argoproj:master Sep 25, 2023
20 checks passed
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 13, 2023
Signed-off-by: Kostis (Codefresh) <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Kostis (Codefresh) <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Kostis (Codefresh) <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
@kostis-codefresh kostis-codefresh deleted the clarify-architecture branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants