fix: analysis step should be ignored after promote #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was inconclusive Signed-off-by: pashakostohrys <[email protected]>
pasha-codefresh
force-pushed
the
fix/inconclusive-analysis-promote
branch
from
c6698ba to
f7d6764
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3016 +/- ##
=======================================
Coverage 81.74% 81.75%
=======================================
Files 134 134
Lines 20386 20395 +9
=======================================
+ Hits 16665 16674 +9
Misses 2865 2865
Partials 856 856
☔ View full report in Codecov by Sentry. |
…was inconclusive Signed-off-by: pashakostohrys <[email protected]>
…e' into fix/inconclusive-analysis-promote # Conflicts: # pkg/kubectl-argo-rollouts/cmd/promote/promote.go
|
Kudos, SonarCloud Quality Gate passed!
|
|
@zachaller could you please review? it is an issue that i showed to you |
|
Why codegen fails in this PR? i didnt change anything related to it |
Seems to have just been a bad run, I re-ran it and its good now |
|
Thank you @zachaller |
zachaller
approved these changes
Sep 5, 2023
zachaller
added
cherry-pick/release-1.6
cherry-pick-completed
zachaller
pushed a commit
that referenced
this pull request
Sep 5, 2023
* fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> * fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 13, 2023
* fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> * fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
* fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> * fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Philip Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3015