Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update datadog.md - clarify formulas #2813 #2819

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

alexef
Copy link
Member

@alexef alexef commented Jun 2, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Go Published Test Results

1 988 tests   1 988 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit d9b4d86.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 26m 33s ⏱️
  96 tests   81 ✔️   5 💤 10
396 runs  364 ✔️ 20 💤 12

For more details on these failures, see this check.

Results for commit d9b4d86.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (906f9a9) 81.69% compared to head (d9b4d86) 81.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2819   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         133      133           
  Lines       20184    20184           
=======================================
  Hits        16489    16489           
  Misses       2843     2843           
  Partials      852      852           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@meeech
Copy link
Contributor

meeech commented Jun 4, 2023

q: Is this a known limitation of the DD api? Or just a stop gap while the formulas for apiv2 are fixed?

@alexef
Copy link
Member Author

alexef commented Jun 5, 2023

just a stop gap

@zachaller zachaller merged commit b853c29 into argoproj:master Jun 6, 2023
@alexef alexef deleted the patch-3 branch June 6, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants