chore(deps): replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` #2681

Juneezee · 2023-03-26T15:44:41Z

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

The package github.com/ghodss/yaml is no longer actively maintained. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

github-actions · 2023-03-26T15:54:06Z

Go Published Test Results

1 950 tests 1 950 ✔️ 2m 36s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit 62ef835.

♻️ This comment has been updated with latest results.

codecov · 2023-03-26T15:55:01Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (f72e565) 81.63% compared to head (62ef835) 81.63%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2681   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files         133      133           
  Lines       20163    20163           
=======================================
  Hits        16460    16460           
  Misses       2849     2849           
  Partials      854      854

Impacted Files	Coverage Δ
pkg/kubectl-argo-rollouts/cmd/create/create.go	`64.96% <ø> (ø)`
pkg/kubectl-argo-rollouts/cmd/lint/lint.go	`85.84% <ø> (ø)`
utils/unstructured/unstructured.go	`74.32% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-03-26T16:20:17Z

E2E Tests Published Test Results

    4 files     4 suites 3h 27m 12s ⏱️
  96 tests   82 ✔️   5 💤   9 ❌
410 runs 364 ✔️ 20 💤 26 ❌

For more details on these failures, see this check.

Results for commit 62ef835.

♻️ This comment has been updated with latest results.

At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]>