Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apache APISIX SetHeader support. Fixes #2668 #2678

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

shareinto
Copy link
Contributor

Fixes #2668

Integrate Apache APISIX Ingress Controller and argo-rollouts using APISIX's CRD

Signed-off-by: shareinto [email protected]
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: shareinto <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Go Published Test Results

1 947 tests   1 947 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 6b62c93.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 76.95% and project coverage change: -0.05 ⚠️

Comparison is base (aa47e41) 81.52% compared to head (6b62c93) 81.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
- Coverage   81.52%   81.47%   -0.05%     
==========================================
  Files         133      133              
  Lines       19866    20152     +286     
==========================================
+ Hits        16195    16419     +224     
- Misses       2836     2881      +45     
- Partials      835      852      +17     
Impacted Files Coverage Δ
rollout/trafficrouting/apisix/apisix.go 81.98% <76.85%> (-8.42%) ⬇️
pkg/apis/rollouts/validation/validation.go 95.57% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 24m 4s ⏱️
  96 tests   81 ✔️   5 💤 10
404 runs  365 ✔️ 20 💤 19

For more details on these failures, see this check.

Results for commit 6b62c93.

♻️ This comment has been updated with latest results.

Signed-off-by: shareinto <[email protected]>
test/e2e/apisix_test.go Outdated Show resolved Hide resolved
@zachaller
Copy link
Collaborator

Signed-off-by: shareinto <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
19.1% 19.1% Duplication

@zachaller zachaller merged commit 8aaae5a into argoproj:master Mar 24, 2023
@shareinto shareinto deleted the feat/apisix-setheader branch March 25, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache APISIX SetHeader Support
2 participants