Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node version and set openssl-legacy-provider #2606

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Feb 18, 2023

This PR fixes the build pipeline again because of changes in github runners that upgrade node to version 18 actions/runner-images#7002 this caused
isses with hash generation functions that were depricated.

This turns on the legacy hash until I can spend time debugging front end deps.

Created an issue to track fixing this all properly #2609

This was the error from pipeline

$ rm -rf dist && webpack --config ./src/app/webpack.prod.js
/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:133
		if(isError) throw e;
		            ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/webpack/lib/NormalModule.js:471:10)
    at /home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/webpack/lib/NormalModule.js:503:5
    at /home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/webpack/lib/NormalModule.js:358:12
    at /home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
    at /home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:236:3
    at context.callback (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at makeSourceMapAndFinish (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/ts-loader/dist/index.js:58:5)
    at successLoader (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/ts-loader/dist/index.js:40:5)
    at Object.loader (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/ts-loader/dist/index.js:23:5)
    at LOADER_EXECUTION (/home/runner/work/argo-rollouts/argo-rollouts/ui/node_modules/loader-runner/lib/LoaderRunner.js:119:14) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Signed-off-by: zachaller <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

Go Published Test Results

1 859 tests   1 859 ✔️  2m 31s ⏱️
   113 suites         0 💤
       1 files           0

Results for commit e9541b3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 42m 27s ⏱️
  96 tests   89 ✔️ 3 💤 4
196 runs  186 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit e9541b3.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@zachaller zachaller changed the title chore: bump node version chore: bump node version and set openssl-legacy-provider Feb 18, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 81.52% // Head: 81.52% // No change to project coverage 👍

Coverage data is based on head (e9541b3) compared to base (e79d1ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2606   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         131      131           
  Lines       19562    19562           
=======================================
  Hits        15947    15947           
  Misses       2795     2795           
  Partials      820      820           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller requested a review from leoluz February 19, 2023 02:54
@zachaller zachaller marked this pull request as ready for review February 19, 2023 02:54
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! @zachaller Would you work on #2609? Otherwise I can also look into it.

@zachaller
Copy link
Collaborator Author

I would love the help looking into it I don't have much webpack experience.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit b273f86 into argoproj:master Feb 20, 2023
zachaller added a commit that referenced this pull request Feb 24, 2023
* bump node version

Signed-off-by: zachaller <[email protected]>

* add legacy flag as a workaround

Signed-off-by: zachaller <[email protected]>

---------

Signed-off-by: zachaller <[email protected]>
zachaller added a commit that referenced this pull request Feb 24, 2023
* bump node version

Signed-off-by: zachaller <[email protected]>

* add legacy flag as a workaround

Signed-off-by: zachaller <[email protected]>

---------

Signed-off-by: zachaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants