Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix dependabot broken dependency with expr lib #2529

Merged
merged 1 commit into from
Jan 20, 2023
Merged

chore: fix dependabot broken dependency with expr lib #2529

merged 1 commit into from
Jan 20, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jan 20, 2023 •
edited
Loading

Dependabot upgrade a dependency that broke our unit tests and possibly features. I submitted an issue here but also am going to look into why the failing test did not stop the automerge of dependabot.

Here is the automerged PR #2527

@zachaller zachaller marked this pull request as ready for review January 20, 2023 17:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@zachaller zachaller requested a review from leoluz January 20, 2023 17:19
@zachaller zachaller changed the title chore: fix dependabot broken dependency chore: fix dependabot broken dependency with expr Jan 20, 2023
@zachaller zachaller changed the title chore: fix dependabot broken dependency with expr chore: fix dependabot broken dependency with expr lib Jan 20, 2023
@github-actions
Copy link
Contributor

Go Published Test Results

1 834 tests   1 834 ✔️  2m 32s ⏱️
   105 suites         0 💤
       1 files           0 ❌

Results for commit a185ca3.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited
Loading

E2E Tests Published Test Results

    2 files      2 suites   1h 38m 49s ⏱️
  95 tests   90 ✔️ 3 💤 2 ❌
192 runs  184 ✔️ 6 💤 2 ❌

For more details on these failures, see this check.

Results for commit a185ca3.

♻️ This comment has been updated with latest results.

leoluz
leoluz approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 8a6416a into argoproj:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachaller @leoluz