chore: disable docker sbom and attestations #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zachaller Not sure how far back you want to cherry pick this. |
Signed-off-by: Justin Marquis <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 81.69% // Head: 81.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2528 +/- ##
=======================================
Coverage 81.69% 81.69%
=======================================
Files 126 126
Lines 19136 19136
=======================================
Hits 15634 15634
Misses 2709 2709
Partials 793 793 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zachaller
approved these changes
Jan 20, 2023
zachaller
pushed a commit
that referenced
this pull request
Feb 24, 2023
Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: zachaller <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
Feb 24, 2023
Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: Justin Marquis <[email protected]>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Marquis [email protected]
The newer BuildKit v0.11 now enables a provenance attestation by default. These attestations are stored as a manifest object of
unknown on unknownattached to the root image index object."To prevent container runtimes from accidentally pulling or running the image described in the manifest, the platform property of the attestation manifest will be set to unknown/unknown"This prevents our current Sbom generation from working properly.This PR is a workaround by disabling attestations and sboms by default. These new inputs for the
docker build and push actionrequire the newer version of build and push.Note: I have tested this workaround locally.