argo-rollouts Dashboard not supporting Rollback

[himanshuupadhyay101]

Describe the bug
When using a Rollouts Dashboard that uses workloadRef :

• The "Rollback" button to rollback to previous revisions don't work -- clicking it doesn't do anything.
• The same issue is also been commented on another issue that is already closed here
• However Rollback is working fine with CLI, but we need to rollback from UI to rollback faster in case of any issues.
• According to our findings, In the controller code the workloadref is handled that is why it works with CLI whereas it is not handled in the Dashboard code here

Version
v1.3.1+b0b95ca

Logs

# Logs for the entire controller:
time="2022-12-07T14:45:52Z" level=info msg="Start processing" resource=production/registry-live
time="2022-12-07T14:45:52Z" level=info msg="Started syncing rollout" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T14:45:52Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=production rollout=registry-live
time="2022-12-07T14:45:52Z" level=info msg="Reconciling TrafficRouting with type 'Istio'" namespace=production rollout=registry-live
time="2022-12-07T14:45:52Z" level=info msg="No StableRS exists to reconcile or matches newRS" namespace=production rollout=registry-live
time="2022-12-07T14:45:52Z" level=info msg="No Steps remain in the canary steps" namespace=production rollout=registry-live
time="2022-12-07T14:45:52Z" level=info msg="Trigger on-analysis-run-failed result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [analysis-run-failed] false}]" resource=production/registry-live
time="2022-12-07T14:45:52Z" level=info msg="Trigger on-rollout-aborted result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [rollout-aborted] false}]" resource=production/registry-live
time="2022-12-07T14:45:52Z" level=info msg="Trigger on-rollout-completed result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [rollout-completed] false}]" resource=production/registry-live
time="2022-12-07T14:45:52Z" level=info msg="Processing completed" resource=production/registry-live
time="2022-12-07T14:45:52Z" level=info msg="No status changes. Skipping patch" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T14:45:52Z" level=info msg="Reconciliation completed" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live time_ms=4.829497
time="2022-12-07T14:45:53Z" level=info msg="Started syncing rollout" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="Reconciling TrafficRouting with type 'Istio'" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="No StableRS exists to reconcile or matches newRS" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="No Steps remain in the canary steps" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live time_ms=4.3544719999999995
time="2022-12-07T14:45:53Z" level=info msg="Started syncing Analysis at (2022-12-07 14:45:53.154596645 +0000 UTC m=+112960.467003381)" analysisrun=registry-live-7b5876c4f7-25 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="Started syncing Analysis at (2022-12-07 14:45:53.154799472 +0000 UTC m=+112960.467206208)" analysisrun=registry-live-8495bf958b-27 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-7b5876c4f7-25 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-7b5876c4f7-25 namespace=production time_ms=0.633641
time="2022-12-07T14:45:53Z" level=info msg="Started syncing Analysis at (2022-12-07 14:45:53.155261017 +0000 UTC m=+112960.467667753)" analysisrun=registry-live-95c9686b4-26 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-8495bf958b-27 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-8495bf958b-27 namespace=production time_ms=0.5868289999999999
time="2022-12-07T14:45:53Z" level=info msg="Started syncing Analysis at (2022-12-07 14:45:53.155439382 +0000 UTC m=+112960.467846118)" analysisrun=registry-live-8495bf958b-29 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-95c9686b4-26 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-95c9686b4-26 namespace=production time_ms=0.481905
time="2022-12-07T14:45:53Z" level=info msg="Started syncing Analysis at (2022-12-07 14:45:53.155767473 +0000 UTC m=+112960.468174219)" analysisrun=registry-live-54f74bdb4b-28 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-8495bf958b-29 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-8495bf958b-29 namespace=production time_ms=0.576349
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-54f74bdb4b-28 namespace=production
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-54f74bdb4b-28 namespace=production time_ms=0.5014559999999999
time="2022-12-07T14:45:53Z" level=info msg="Started syncing rollout" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="Reconciling TrafficRouting with type 'Istio'" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="No StableRS exists to reconcile or matches newRS" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="No Steps remain in the canary steps" namespace=production rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="No status changes. Skipping patch" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T14:45:53Z" level=info msg="Reconciliation completed" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live time_ms=4.231038000000001
time="2022-12-07T15:00:52Z" level=info msg="Start processing" resource=production/registry-live
time="2022-12-07T15:00:52Z" level=info msg="Started syncing rollout" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T15:00:52Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=production rollout=registry-live
time="2022-12-07T15:00:52Z" level=info msg="Reconciling TrafficRouting with type 'Istio'" namespace=production rollout=registry-live
time="2022-12-07T15:00:52Z" level=info msg="No StableRS exists to reconcile or matches newRS" namespace=production rollout=registry-live
time="2022-12-07T15:00:52Z" level=info msg="No Steps remain in the canary steps" namespace=production rollout=registry-live
time="2022-12-07T15:00:52Z" level=info msg="Trigger on-rollout-aborted result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [rollout-aborted] false}]" resource=production/registry-live
time="2022-12-07T15:00:52Z" level=info msg="Trigger on-rollout-completed result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [rollout-completed] false}]" resource=production/registry-live
time="2022-12-07T15:00:52Z" level=info msg="Trigger on-analysis-run-failed result: [{[0].2jmj7l5rSw0yVb_vlWAYkK_YBwk  [analysis-run-failed] false}]" resource=production/registry-live
time="2022-12-07T15:00:52Z" level=info msg="Processing completed" resource=production/registry-live
time="2022-12-07T15:00:52Z" level=info msg="No status changes. Skipping patch" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T15:00:52Z" level=info msg="Reconciliation completed" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live time_ms=4.90803
time="2022-12-07T15:00:53Z" level=info msg="Started syncing rollout" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="Reconciling TrafficRouting with type 'Istio'" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="No StableRS exists to reconcile or matches newRS" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="No Steps remain in the canary steps" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live time_ms=4.530187
time="2022-12-07T15:00:53Z" level=info msg="Started syncing Analysis at (2022-12-07 15:00:53.155715158 +0000 UTC m=+113860.468121904)" analysisrun=registry-live-54f74bdb4b-28 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Started syncing Analysis at (2022-12-07 15:00:53.156039269 +0000 UTC m=+113860.468446005)" analysisrun=registry-live-7b5876c4f7-25 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Started syncing Analysis at (2022-12-07 15:00:53.156234875 +0000 UTC m=+113860.468641611)" analysisrun=registry-live-8495bf958b-27 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-54f74bdb4b-28 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-54f74bdb4b-28 namespace=production time_ms=0.62153
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-7b5876c4f7-25 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-7b5876c4f7-25 namespace=production time_ms=1.003752
time="2022-12-07T15:00:53Z" level=info msg="Started syncing Analysis at (2022-12-07 15:00:53.157514747 +0000 UTC m=+113860.469921493)" analysisrun=registry-live-95c9686b4-26 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Started syncing Analysis at (2022-12-07 15:00:53.158137427 +0000 UTC m=+113860.470544173)" analysisrun=registry-live-8495bf958b-29 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-8495bf958b-27 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-8495bf958b-27 namespace=production time_ms=2.712758
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-95c9686b4-26 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-95c9686b4-26 namespace=production time_ms=1.4681080000000002
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" analysisrun=registry-live-8495bf958b-29 namespace=production
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" analysisrun=registry-live-8495bf958b-29 namespace=production time_ms=2.5294119999999998
time="2022-12-07T15:00:53Z" level=info msg="Started syncing rollout" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="Reconciling TrafficRouting with type 'Istio'" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="No StableRS exists to reconcile or matches newRS" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="No Steps remain in the canary steps" namespace=production rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="No status changes. Skipping patch" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live
time="2022-12-07T15:00:53Z" level=info msg="Reconciliation completed" generation=8 namespace=production resourceVersion=188516604 rollout=registry-live time_ms=4.796266

---

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[zachaller]

Related #2259

[himanshuupadhyay101]

Related #2259

In my case it doesn't rollbacks to the previous revision via UI however in #2259 it was still rollbacking to previous revision. and i was getting a 500 for the PUT call to /api/v1/rollouts/production/registry-live/undo/27 path as shown in the snapshot above.

[zachaller]

I am unable to reproduce this using the example here on the master branch

[meeech]

I just tested on v1.4.0+e40c9fe and can confirm rollback works when using a rollout with workloadRef to a deployment.

[tukak]

I think this was fixed in 22ff2c4, shipped in 1.4.0

[github-actions]

This issue is stale because it has awaiting-response label for 5 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity and has the awaiting-response label.