Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Issue #1779: add rollout.Spec.Strategy.Canary.MinPodsPerReplicaSet #2448

Merged
merged 11 commits into from
Dec 19, 2022

Conversation

ssanders1449
Copy link
Contributor

@ssanders1449 ssanders1449 commented Dec 2, 2022

Implements issue #1779
See #1779 for Use Cases

This is option 1 from #1779 (comment)

Signed-off-by: Shlomo Sanders [email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Go Published Test Results

1 833 tests   1 833 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit aab92b8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 34m 27s ⏱️
  94 tests   87 ✔️ 3 💤 4
192 runs  182 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit aab92b8.

♻️ This comment has been updated with latest results.

Signed-off-by: Shlomo Sanders <[email protected]>
@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 81.67% // Head: 81.68% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (aab92b8) compared to base (f5fb4c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2448   +/-   ##
=======================================
  Coverage   81.67%   81.68%           
=======================================
  Files         126      126           
  Lines       19124    19132    +8     
=======================================
+ Hits        15620    15628    +8     
  Misses       2710     2710           
  Partials      794      794           
Impacted Files Coverage Δ
utils/replicaset/canary.go 92.85% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Shlomo Sanders <[email protected]>
@ssanders1449
Copy link
Contributor Author

@zachaller
Please take a look at this PR

@ssanders1449 ssanders1449 force-pushed the issue_1779_MinPodsPerRS branch from d247f32 to 9db92cd Compare December 11, 2022 21:41
Signed-off-by: Shlomo Sanders <[email protected]>
@ssanders1449 ssanders1449 changed the title feat: Implement Issue #1779: add rollout.Spec.Strategy.Canary.MinPodsPerRS feat: Implement Issue #1779: add rollout.Spec.Strategy.Canary.MinPodsPerReplicaSet Dec 11, 2022
@zachaller
Copy link
Collaborator

zachaller commented Dec 12, 2022

Sorry should have caught this in my first look as well. Can we get some docs added to at least the specs page https://argoproj.github.io/argo-rollouts/features/specification/

Signed-off-by: Shlomo Sanders <[email protected]>
@zachaller
Copy link
Collaborator

I want to get this in 1.4 can you please resolve conflicts?

Signed-off-by: zachaller <[email protected]>
@zachaller
Copy link
Collaborator

actually nm, i see you enabled maintainers to pushed it was just a codegen issue so I was able to fix it :D

@zachaller zachaller added this to the v1.4 milestone Dec 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

@zachaller zachaller merged commit 4874b94 into argoproj:master Dec 19, 2022
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
….MinPodsPerReplicaSet (argoproj#2448)

* add rollout.Spec.Strategy.Canary.MinPodsPerRS (for TrafficRoutedCanary only)

Signed-off-by: Shlomo Sanders <[email protected]>

* fix lint and test

Signed-off-by: Shlomo Sanders <[email protected]>

* fix codegen

Signed-off-by: Shlomo Sanders <[email protected]>

* rename MinPodsPerRS to MinPodsPerReplicaSet

Signed-off-by: Shlomo Sanders <[email protected]>

* fix lint and codegen

Signed-off-by: Shlomo Sanders <[email protected]>

* update specification.md

Signed-off-by: Shlomo Sanders <[email protected]>

* codegen

Signed-off-by: zachaller <[email protected]>

* codegen missed a file

Signed-off-by: zachaller <[email protected]>

Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: Shlomo Sanders <[email protected]>
Co-authored-by: zachaller <[email protected]>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
….MinPodsPerReplicaSet (argoproj#2448)

* add rollout.Spec.Strategy.Canary.MinPodsPerRS (for TrafficRoutedCanary only)

Signed-off-by: Shlomo Sanders <[email protected]>

* fix lint and test

Signed-off-by: Shlomo Sanders <[email protected]>

* fix codegen

Signed-off-by: Shlomo Sanders <[email protected]>

* rename MinPodsPerRS to MinPodsPerReplicaSet

Signed-off-by: Shlomo Sanders <[email protected]>

* fix lint and codegen

Signed-off-by: Shlomo Sanders <[email protected]>

* update specification.md

Signed-off-by: Shlomo Sanders <[email protected]>

* codegen

Signed-off-by: zachaller <[email protected]>

* codegen missed a file

Signed-off-by: zachaller <[email protected]>

Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: Shlomo Sanders <[email protected]>
Co-authored-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants