-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Issue #1779: add rollout.Spec.Strategy.Canary.MinPodsPerReplicaSet #2448
feat: Implement Issue #1779: add rollout.Spec.Strategy.Canary.MinPodsPerReplicaSet #2448
Conversation
…y only) Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Shlomo Sanders <[email protected]>
Codecov ReportBase: 81.67% // Head: 81.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
=======================================
Coverage 81.67% 81.68%
=======================================
Files 126 126
Lines 19124 19132 +8
=======================================
+ Hits 15620 15628 +8
Misses 2710 2710
Partials 794 794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Shlomo Sanders <[email protected]>
@zachaller |
Signed-off-by: Shlomo Sanders <[email protected]>
d247f32
to
9db92cd
Compare
Signed-off-by: Shlomo Sanders <[email protected]>
Sorry should have caught this in my first look as well. Can we get some docs added to at least the specs page https://argoproj.github.io/argo-rollouts/features/specification/ |
Signed-off-by: Shlomo Sanders <[email protected]>
I want to get this in 1.4 can you please resolve conflicts? |
Signed-off-by: zachaller <[email protected]>
actually nm, i see you enabled maintainers to pushed it was just a codegen issue so I was able to fix it :D |
…_1779_MinPodsPerRS Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
….MinPodsPerReplicaSet (argoproj#2448) * add rollout.Spec.Strategy.Canary.MinPodsPerRS (for TrafficRoutedCanary only) Signed-off-by: Shlomo Sanders <[email protected]> * fix lint and test Signed-off-by: Shlomo Sanders <[email protected]> * fix codegen Signed-off-by: Shlomo Sanders <[email protected]> * rename MinPodsPerRS to MinPodsPerReplicaSet Signed-off-by: Shlomo Sanders <[email protected]> * fix lint and codegen Signed-off-by: Shlomo Sanders <[email protected]> * update specification.md Signed-off-by: Shlomo Sanders <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> * codegen missed a file Signed-off-by: zachaller <[email protected]> Signed-off-by: Shlomo Sanders <[email protected]> Signed-off-by: zachaller <[email protected]> Co-authored-by: Shlomo Sanders <[email protected]> Co-authored-by: zachaller <[email protected]>
….MinPodsPerReplicaSet (argoproj#2448) * add rollout.Spec.Strategy.Canary.MinPodsPerRS (for TrafficRoutedCanary only) Signed-off-by: Shlomo Sanders <[email protected]> * fix lint and test Signed-off-by: Shlomo Sanders <[email protected]> * fix codegen Signed-off-by: Shlomo Sanders <[email protected]> * rename MinPodsPerRS to MinPodsPerReplicaSet Signed-off-by: Shlomo Sanders <[email protected]> * fix lint and codegen Signed-off-by: Shlomo Sanders <[email protected]> * update specification.md Signed-off-by: Shlomo Sanders <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> * codegen missed a file Signed-off-by: zachaller <[email protected]> Signed-off-by: Shlomo Sanders <[email protected]> Signed-off-by: zachaller <[email protected]> Co-authored-by: Shlomo Sanders <[email protected]> Co-authored-by: zachaller <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Implements issue #1779
See #1779 for Use Cases
This is option 1 from #1779 (comment)
Signed-off-by: Shlomo Sanders [email protected]