fix(cli): nil pointer while linting #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <[email protected]>
zachaller
changed the title
zachaller
changed the title
Signed-off-by: zachaller <[email protected]>
Codecov ReportBase: 82.38% // Head: 82.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
+ Coverage 82.38% 82.76% +0.38%
==========================================
Files 121 121
Lines 18476 18522 +46
==========================================
+ Hits 15221 15330 +109
+ Misses 2468 2408 -60
+ Partials 787 784 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
* fix nil pointer on lint Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * add test for having a virtual service but not using it in rollout Signed-off-by: zachaller <[email protected]> * change logic Signed-off-by: zachaller <[email protected]> * improve test cov Signed-off-by: zachaller <[email protected]> * remove unreachable code Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * Add test coverage Signed-off-by: zachaller <[email protected]> * add more test coverage Signed-off-by: zachaller <[email protected]> * Standardize msg Signed-off-by: zachaller <[email protected]> * lint Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
* fix nil pointer on lint Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * add test for having a virtual service but not using it in rollout Signed-off-by: zachaller <[email protected]> * change logic Signed-off-by: zachaller <[email protected]> * improve test cov Signed-off-by: zachaller <[email protected]> * remove unreachable code Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * Add test coverage Signed-off-by: zachaller <[email protected]> * add more test coverage Signed-off-by: zachaller <[email protected]> * Standardize msg Signed-off-by: zachaller <[email protected]> * lint Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
* fix nil pointer on lint Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * add test for having a virtual service but not using it in rollout Signed-off-by: zachaller <[email protected]> * change logic Signed-off-by: zachaller <[email protected]> * improve test cov Signed-off-by: zachaller <[email protected]> * remove unreachable code Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * github trigger re-run Signed-off-by: zachaller <[email protected]> * Add test coverage Signed-off-by: zachaller <[email protected]> * add more test coverage Signed-off-by: zachaller <[email protected]> * Standardize msg Signed-off-by: zachaller <[email protected]> * lint Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2322
Signed-off-by: zachaller [email protected]