fix(analysis): Avoid Infinite Error Message Append For Failed Dry-Run Metrics #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Metrics Signed-off-by: Rohit Agrawal <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
==========================================
+ Coverage 82.24% 82.37% +0.13%
==========================================
Files 121 121
Lines 17969 18069 +100
==========================================
+ Hits 14778 14884 +106
+ Misses 2421 2416 -5
+ Partials 770 769 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
harikrongali
approved these changes
Aug 11, 2022
leoluz
approved these changes
Aug 11, 2022
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
… Metrics (argoproj#2182) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
… Metrics (argoproj#2182) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
… Metrics (argoproj#2182) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small fix to only include the most recent error message for the dry-run metric failures. If we don't do this and there are other wet-metrics in progress then the error message keeps getting appended infinitely.
Checklist
"fix(controller): Updates such and such. Fixes #1234".Signed-off-by: Rohit Agrawal [email protected]