Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client.authentication.k8s.io/v1 #1741

Closed
mvgmb opened this issue Jan 3, 2022 · 0 comments · Fixed by #1773
Closed

Support client.authentication.k8s.io/v1 #1741

mvgmb opened this issue Jan 3, 2022 · 0 comments · Fixed by #1773
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mvgmb
Copy link
Contributor

mvgmb commented Jan 3, 2022

Summary

Bump kubernetes/client-go to v0.22 to support client.authentication.k8s.io/v1.

Without this new version of kubernetes/client-go, users authenticating via client.authentication.k8s.io/v1 will not be able to use the plugin.

Use Cases

Dashboard authentication via client.authentication.k8s.io/v1. Currently it results in:

$ kubectl argo rollouts -n namespace dashboard
panic: exec plugin: invalid apiVersion "client.authentication.k8s.io/v1"

goroutine 1 [running]:
github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/options.(*ArgoRolloutsOptions).KubeClientset(0xc000289a20, 0x7ffeefbff810, 0x9)
        /go/src/github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/options/options.go:130 +0xfe
github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/cmd/dashboard.NewCmdDashboard.func1(0xc00013db80, 0xc0005681e0, 0x0, 0x2, 0x0, 0x0)
        /go/src/github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/cmd/dashboard/dashboard.go:17 +0x67
github.com/spf13/cobra.(*Command).execute(0xc00013db80, 0xc000599fe0, 0x2, 0x2, 0xc00013db80, 0xc000599fe0)
        /go/pkg/mod/github.com/spf13/[email protected]/command.go:850 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc0005a4580, 0xc0005a4580, 0x3278760, 0xc0001a0008)
        /go/pkg/mod/github.com/spf13/[email protected]/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /go/pkg/mod/github.com/spf13/[email protected]/command.go:895
main.main()
        /go/src/github.com/argoproj/argo-rollouts/cmd/kubectl-argo-rollouts/main.go:21 +0xc5

References

Message from the maintainers

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants