Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release assets appear to be missing dashboard install manifest #1594

Closed
greenkiwi opened this issue Oct 18, 2021 · 3 comments · Fixed by #1601
Closed

Release assets appear to be missing dashboard install manifest #1594

greenkiwi opened this issue Oct 18, 2021 · 3 comments · Fixed by #1601
Labels
bug Something isn't working

Comments

@greenkiwi
Copy link

greenkiwi commented Oct 18, 2021

Summary

We are using kustomize to deploy argo-rollouts. We would like to deploy the dashboard, but the manifest install file is missing from the release.

As it stands, we have to add the resources and then overwrite the tag.

resources:
  - https://github.com/argoproj/argo-rollouts/releases/download/v1.1.0/install.yaml
  - https://github.com/argoproj/argo-rollouts/manifests/dashboard-install?ref=v1.1.0

images:
  - name: quay.io/argoproj/kubectl-argo-rollouts
    newTag: v1.1.0

Can a dashboard-install.yaml be added to the resources associated with a release? (And or is there a better way to install the dashboard?)

Note, we are following the shift to using release assets rather than files in the repo as outlined here: #1456


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@greenkiwi greenkiwi added the bug Something isn't working label Oct 18, 2021
@jessesuen
Copy link
Member

Ah yes you're right. They are missing

@greenkiwi
Copy link
Author

@jessesuen Does it make sense to also have the rollout transform as a release asset?

We are having to add it to kustomization.yaml with a URL to the raw file:

https://raw.githubusercontent.com/argoproj/argo-rollouts/v1.1.0/docs/features/kustomize/rollout-transform.yaml

Should I file a second ticket for that?

@perenesenko
Copy link
Member

I forgot to include it in the artifacts.
Here is a fix for that
PR: #1601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants