Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add age to AnalysisRun printer columns #1511

Closed
yashmehrotra opened this issue Sep 15, 2021 · 3 comments
Closed

Add age to AnalysisRun printer columns #1511

yashmehrotra opened this issue Sep 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@yashmehrotra
Copy link
Contributor

yashmehrotra commented Sep 15, 2021

Summary

Add an AGE parameter to AnalysisRun printer columns for ease of viewing

Use Cases

When debugging why a canary rolled back, doing a kubectl get of AnalysisRun returns just the name and status. While the name being composed of the replicaset makes things easier, I found that adding the Age parameter helps tremendously.

The only change we need to make is to add this to the additonalPrinterColumns in the CRD

    - jsonPath: .metadata.creationTimestamp
      name: Age
      type: date

If you are interested in having this change, I'd love to contribute 😄

I added this in my cluster's deployment and it helped the team a lot. This is how it looks:

image


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@yashmehrotra yashmehrotra added the enhancement New feature or request label Sep 15, 2021
@huikang
Copy link
Member

huikang commented Sep 21, 2021

Sounds a good idea. @yashmehrotra , could you send a PR to enable this? Thanks.

@yashmehrotra
Copy link
Contributor Author

@huikang Awesome, I'll create a PR for this, I hope it is fine if I do it for all the CRDs:

  • analysisruns.argoproj.io
  • analysistemplates.argoproj.io
  • clusteranalysistemplates.argoproj.io
  • experiments.argoproj.io
  • rollouts.argoproj.io

@yashmehrotra
Copy link
Contributor Author

@huikang Have created a PR: #1527

Please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants