Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genenerate x-kubernetes-patch-merge-key and x-kubernetes-patch-strategy #1210

Closed
jessesuen opened this issue May 21, 2021 · 2 comments · Fixed by #1371
Closed

genenerate x-kubernetes-patch-merge-key and x-kubernetes-patch-strategy #1210

jessesuen opened this issue May 21, 2021 · 2 comments · Fixed by #1371
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jessesuen
Copy link
Member

jessesuen commented May 21, 2021

Summary

Kustomize 4 has finally has a mechanism to teach it how to SMP custom resources. See:

In order for kustomize to patch CRDs properly, we need to publish openAPI schema containing the following metadata in the Rollout CRD definitions.

  • x-kubernetes-patch-merge-key
  • x-kubernetes-patch-strategy

This will lower the barrier of entry to Rollouts and cause less surprising behavior.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@jessesuen jessesuen added the enhancement New feature or request label May 21, 2021
@jessesuen jessesuen added this to the v1.1 milestone May 21, 2021
@jessesuen jessesuen changed the title genenerate kubernetes-patch-merge-key and x-kubernetes-patch-strategy genenerate x-kubernetes-patch-merge-key and x-kubernetes-patch-strategy May 21, 2021
@huikang
Copy link
Member

huikang commented Jul 20, 2021

@jessesuen , I can pick this up; please assign it to me. Thanks.

@jessesuen
Copy link
Member Author

Thanks @huikang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants