Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StepsHash is not stable #103

Closed
jessesuen opened this issue Jun 12, 2019 · 0 comments · Fixed by #108
Closed

StepsHash is not stable #103

jessesuen opened this issue Jun 12, 2019 · 0 comments · Fixed by #108
Labels
bug Something isn't working
Milestone
v0.4

Comments

@jessesuen
Copy link
Member

jessesuen commented Jun 12, 2019 •
edited
Loading

Similar to #88, the function to calculate the steps hash is not stable any time we change the steps type definition. We need to have a stable hashing function or else adding new types of steps will break suspended canary rollouts, causing them to start back at step 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4
1 participant
@jessesuen