Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD validation needs to be removed for resource requests/limits #101

Closed
jessesuen opened this issue Jun 7, 2019 · 0 comments · Fixed by #105
Closed

CRD validation needs to be removed for resource requests/limits #101

jessesuen opened this issue Jun 7, 2019 · 0 comments · Fixed by #105
Labels
bug Something isn't working
Milestone

Comments

@jessesuen
Copy link
Member

Since adding resource validation for pod template, it seems that removed the ability to set numeric values for cpu/memory. This caused kubernetes to reject creations of rollouts with floating point/integer cpu/mem requests/limits. We need to remove this validation. I added a convenience function to do this, which just needs to be add more for resource cpu/memory.

removeValidataion(&un, "spec.template.metadata.creationTimestamp")
@jessesuen jessesuen added the bug Something isn't working label Jun 7, 2019
@jessesuen jessesuen added this to the v0.4.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant