Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included redis-exporter doesn't support arm64 arch #2233

Closed
svyatoslavmo opened this issue Aug 25, 2023 · 12 comments · Fixed by #2236
Closed

Included redis-exporter doesn't support arm64 arch #2233

svyatoslavmo opened this issue Aug 25, 2023 · 12 comments · Fixed by #2236
Labels
argo-cd bug Something isn't working

Comments

@svyatoslavmo
Copy link

Describe the bug

Included redis-exporter doesn't support arm64 arch. Also when changing image repo chart renders it incorrectly.

image: ‘map[repository:bitnami/redis-exporter tag:1.46.0]:1.45.0’

Related helm chart

argo-cd

Helm chart version

5.43.7

To Reproduce

Change repository to bitnami/redis-exporter
Change tag to 1.46.0

Expected behavior

You'll be able to change the repo

Screenshots

No response

Additional context

No response

@svyatoslavmo svyatoslavmo added the bug Something isn't working label Aug 25, 2023
@yu-croco
Copy link
Collaborator

yu-croco commented Aug 26, 2023

Hi @svyatoslavmo

when changing image repo chart renders it incorrectly.

It worked with the following value.yaml. Did I miss something ? 🤔

  • first apply with helm install argo-cd . command
redis:
  exporter:
    enabled: true
  • second apply with helm upgrade argo-cd . command
redis:
  exporter:
    enabled: true
    image:
      repository: bitnami/redis-exporter
      tag: 1.46.0

My Helm version is below.

$ helm version
version.BuildInfo{Version:"v3.12.3", GitCommit:"3a31588ad33fe3b89af5a2a54ee1d25bfe6eaa5e", GitTreeState:"clean", GoVersion:"go1.20.7"}

@pdrastil
Copy link
Member

The version 1.46.0 >= should support ARM64
Ref: https://hub.docker.com/r/bitnami/redis-exporter/tags?page=1&name=1.46.0

@svyatoslavmo
Copy link
Author

@pdrastil you can check using docker mainfest inspect public.ecr.aws/bitnami/redis-exporter:1.53.0. Images in public ECR support only amd64.
But same repo in Dockerhub support it docker manifest inspect bitnami/redis-exporter:1.53.0
{ "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json", "manifests": [ { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 429, "digest": "sha256:eebaa52f90059b85b89f1ee6b17b1f57fc66424a75e7523425803c460d87c074", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 429, "digest": "sha256:4ae361307534c4edc876b5547410711f730c42a9da5d8be540f7cc5efba835c0", "platform": { "architecture": "arm64", "os": "linux" } } ] }

@pdrastil
Copy link
Member

@svyatoslavmo It actually supports ARM but I was able to get that image only via

docker pull bitnami/redis-exporter@sha256:4ae361307534c4edc876b5547410711f730c42a9da5d8be540f7cc5efba835c0

@svyatoslavmo
Copy link
Author

@pdrastil pls check public.ecr.aws/bitnami/redis-exporter:1.53.0 using inspect.
Version from ECR doesn't support ARM. But version from Dockerhub do. Is there a reason why this chart uses ECR?

All other components of ArgoCD can be launched on ARM out of the box.

@pdrastil
Copy link
Member

pdrastil commented Aug 26, 2023

Just checked that it's really caused by AWS ECR registry that do not support ARM. The reason is probably historic when DockerHub introduced limits on the pulls from anonymous users. This caused problems in public clouds.

Ref: https://docs.docker.com/docker-hub/download-rate-limit/

@svyatoslavmo
Copy link
Author

@yu-croco I'm applying using latest stable ArgoCD( 2.8.2), helm version is the same. Just checked local helm template . and 1.45.0 is there.

My values:

 redis-ha:
   enabled: true
   replicas: 3
   exporter:
     enabled: true
     image:
       repository: bitnami/redis-exporter
       tag: 1.46.0

@pdrastil
Copy link
Member

@svyatoslavmo redis-ha subchart uses different structure - notice that image is actual repository

redis-ha:
  # -- Enables the Redis HA subchart and disables the custom Redis single node deployment
  enabled: false
  ## Prometheus redis-exporter sidecar
  exporter:
    # -- Enable Prometheus redis-exporter sidecar
    enabled: false
    # -- Repository to use for the redis-exporter
    image: public.ecr.aws/bitnami/redis-exporter
    # -- Tag to use for the redis-exporter
    tag: 1.45.0

@svyatoslavmo
Copy link
Author

@pdrastil oh, thank you! That fixed my issue

@pdrastil
Copy link
Member

Closing as resolved

@FernandoMiguel
Copy link

Just checked that it's really caused by AWS ECR registry that do not support ARM. [...]

wonder if you meant to say something different there, since AWS ECR Public Gallery does support ARM images and multi arch manifests

for ex
image
https://gallery.ecr.aws/cloudwatch-agent/cloudwatch-agent

OTOH binami only very recently started building and pushing ARM images, and i suspect they dont do it to all registries
bitnami/charts#7305 (comment)

@pdrastil
Copy link
Member

@FernandoMiguel I'll try to correct myself. It seems AWS ECR doesn't have ARM image that can be pulled via docker pull --platform linux/arm64 for bitnami redis-exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants