-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reorganize argocd binaries (#5005) #5247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5247 +/- ##
==========================================
+ Coverage 40.86% 41.07% +0.21%
==========================================
Files 136 136
Lines 18453 18365 -88
==========================================
+ Hits 7540 7544 +4
+ Misses 9834 9742 -92
Partials 1079 1079
Continue to review full report at Codecov.
|
889841a
to
b9594ff
Compare
b9594ff
to
434d927
Compare
3a538f5
to
471a47e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two minor comments. Also noticed that we still have a bunch of main.go files:
find . -name "main.go"
./cmd/argocd-server/main.go
./cmd/argocd-util/main.go
./cmd/argocd/main.go
./cmd/argocd-repo-server/main.go
./cmd/argocd-application-controller/main.go
./cmd/main.go
Can you please delete all except ./cmd/main.go
?
a646095
to
a074118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, one last suggestion
Signed-off-by: kshamajain99 <[email protected]>
a074118
to
e1e34a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @kshamajain99
Signed-off-by: kshamajain99 <[email protected]>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
closes #5005