Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reorganize argocd binaries (#5005) #5247

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

kshamajain99
Copy link
Contributor

@kshamajain99 kshamajain99 commented Jan 14, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an [enhancement proposal](Reorganize binaries to reduce image size #5005 and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

closes #5005

  • Adopting busybox approach.
  • Merging argocd(cli), argocd-util, argocd-server, argocd-application-controller, argocd-repo-server into single binary in order to reduce binary size
  • Moving dex tool from argocd-util to argocd-dex

@codecov-io
Copy link

codecov-io commented Jan 14, 2021

Codecov Report

Merging #5247 (e1e34a3) into master (64e1c38) will increase coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5247      +/-   ##
==========================================
+ Coverage   40.86%   41.07%   +0.21%     
==========================================
  Files         136      136              
  Lines       18453    18365      -88     
==========================================
+ Hits         7540     7544       +4     
+ Misses       9834     9742      -92     
  Partials     1079     1079              
Impacted Files Coverage Δ
cmd/argocd-util/commands/argocd_util.go 5.42% <0.00%> (+1.22%) ⬆️
cmd/argocd/commands/root.go 2.22% <0.00%> (ø)
cmd/util/common.go 0.00% <ø> (ø)
util/settings/settings.go 40.51% <ø> (ø)
server/project/project.go 55.46% <0.00%> (-0.92%) ⬇️
cmd/util/app.go 33.43% <0.00%> (-0.32%) ⬇️
reposerver/repository/repository.go 62.60% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e1c38...e1e34a3. Read the comment docs.

cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
tools/cmd-docs/main.go Show resolved Hide resolved
@kshamajain99 kshamajain99 requested a review from alexmt January 19, 2021 03:58
@kshamajain99 kshamajain99 force-pushed the consolidate-binaries branch 3 times, most recently from 3a538f5 to 471a47e Compare January 19, 2021 22:38
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two minor comments. Also noticed that we still have a bunch of main.go files:

find . -name "main.go"                                                                                                                                                      
./cmd/argocd-server/main.go
./cmd/argocd-util/main.go
./cmd/argocd/main.go
./cmd/argocd-repo-server/main.go
./cmd/argocd-application-controller/main.go
./cmd/main.go

Can you please delete all except ./cmd/main.go ?

Makefile Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one last suggestion

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @kshamajain99

@alexmt alexmt merged commit 7af5837 into argoproj:master Jan 20, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize binaries to reduce image size
4 participants