Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADA-ARGO-SA-14: Log a warning if OIDCTLSConfig is nil #9957

Open
crenshaw-dev opened this issue Jul 12, 2022 · 1 comment
Open

ADA-ARGO-SA-14: Log a warning if OIDCTLSConfig is nil #9957

crenshaw-dev opened this issue Jul 12, 2022 · 1 comment
Labels
bug Something isn't working security Security related

Comments

@crenshaw-dev
Copy link
Member

If external (non-bundled Dex) OIDC is not enabled, a.TLSConfig() can return nil. If that happens, we should log a warning here.

argo-cd/util/settings/settings.go

Line 1684 in f223182

tlsConfig = a.TLSConfig()

@crenshaw-dev crenshaw-dev added bug Something isn't working security Security related labels Jul 12, 2022
@notfromstatefarm
Copy link
Contributor

In #9883 we'll be ignoring this TLS config when the internal dex is used.

@crenshaw-dev crenshaw-dev changed the title Log a warning of OIDCTLSConfig is nil Log a warning if OIDCTLSConfig is nil Jul 15, 2022
@crenshaw-dev crenshaw-dev changed the title Log a warning if OIDCTLSConfig is nil ADA-ARGO-SA-14: Log a warning if OIDCTLSConfig is nil Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working security Security related
Projects
Ada Logics audit follow-up
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crenshaw-dev @notfromstatefarm